use List instead of Map for <locals> cell #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
approved these changes
Jun 21, 2024
| @@ -1187,7 +1184,7 @@ The `#take` function will return the parameter stack in the reversed order, then | |||
| ... | |||
| </instrs> | |||
| <valstack> VALSTACK => .ValStack </valstack> | |||
| <locals> LOCAL => .Map </locals> | |||
| <locals> LOCAL </locals> | |||
There was a problem hiding this comment.
Why not use Locals => .List?
There was a problem hiding this comment.
Because this rule is immediately followed by the one for init_locals which rewrites this cell to the empty list.
dwightguth
pushed a commit
that referenced
this pull request
Jun 25, 2024
Robertorosmaninho
pushed a commit
that referenced
this pull request
Jul 9, 2024
dwightguth
pushed a commit
that referenced
this pull request
Jul 9, 2024
dwightguth
pushed a commit
that referenced
this pull request
Aug 6, 2024
dwightguth
pushed a commit
that referenced
this pull request
Aug 9, 2024
Robertorosmaninho
pushed a commit
that referenced
this pull request
Sep 26, 2024
dwightguth
pushed a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review yet.
This PR attempts to optimize the local.get and local.set instructions by means of replacing the Map used by the
<locals>cell with a List.