Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type funtion calls from tests #8

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Remove type funtion calls from tests #8

merged 5 commits into from
Aug 20, 2024

Conversation

mariaKt
Copy link
Contributor

@mariaKt mariaKt commented Aug 19, 2024

This PR removes the type function calls currently present in the tests. It was only used in expressions of the form

type(uint*).max

I opted to use a variable that stores the expected value and use it instead of the function call.

We can make it a constant when/if these are planned.

Edit: Resolves #1750

@mariaKt mariaKt marked this pull request as ready for review August 19, 2024 22:02
@mariaKt mariaKt requested a review from dwightguth August 19, 2024 22:02
@dwightguth dwightguth merged commit 3a8eb32 into main Aug 20, 2024
1 check passed
@dwightguth dwightguth deleted the type-fc branch August 20, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants