Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing transferFrom function summary on dAIMock #58

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

Robertorosmaninho
Copy link
Contributor

@Robertorosmaninho Robertorosmaninho commented Oct 7, 2024

This PR adds the summarized rules regarding the program execution. The rule presented in this PR summarizes the function of transferFrom function on dAIMock.

By summarizing this function, we save 1265 steps.
(Without it, the program took 19055 steps, and after implementing it, the program took 17790 steps)

Wall Time to execute 1000 testSwapSingleHopExactAmountIn summarized:

  • On main branch: 0.176s
  • On this branch: 0.170s

Wall Time to execute 1000 testSwapSingleHopExactAmountIn without any summarization: 0.269s

Copy link
Contributor

@mariaKt mariaKt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested some changes, pertaining to adding side conditions to the rule. Please let me know if I have misunderstood anything.

src/uniswap-summaries.md Outdated Show resolved Hide resolved
@Robertorosmaninho Robertorosmaninho force-pushed the transferFrom-dAIMock-summary branch from 0cca72e to 3f78a0e Compare October 8, 2024 18:24
src/uniswap-summaries.md Show resolved Hide resolved
src/uniswap-summaries.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mariaKt mariaKt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for addressing the comments.

@mariaKt mariaKt merged commit dd6d2d0 into main Oct 10, 2024
1 check passed
@mariaKt mariaKt deleted the transferFrom-dAIMock-summary branch October 10, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants