Introducing approve summary from bind to return on dAIMock
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
force-pushed
the
approve-dAIMock-summary
branch
from
d018c65 to
08f3a10
Compare
Robertorosmaninho
force-pushed
the
approve-dAIMock-summary
branch
from
08f3a10 to
be92a25
Compare
mariaKt
requested changes
Oct 4, 2024
mariaKt
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Before you merge, do either one of the following: (1 - preferred) match the <contract-state> cell, and make sure it includes allowance |-> mapping ... or (2) replace TYPE with dAIMock, so that we are sure that this is within the dAIMock contract, therefore we are indirectly sure that the allowance variable is the one we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the summarized rules regarding the body of program execution. The rule presented in this PR summarizes the body of
approvefunction starting on thebindfunction.By summarizing the body of this function, we save 308 steps.
(Without it, the program took 19933 steps, and after implementing it, the program took 19625 steps)
Wall Time to execute 1000
testSwapSingleHopExactAmountInsummarized:mainbranch:0.179s0.176sWall Time to execute 1000
testSwapSingleHopExactAmountInwithout any summarization:0.263s