Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync UniswapV2SwapRenamed with UniswapV2Swap #36

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

mariaKt
Copy link
Contributor

@mariaKt mariaKt commented Sep 19, 2024

This PR updates UniswapV2SwapRenamed.sol to be in sync with UniswapV2Swap.sol, while applying the same changes as #28, namely:

  • change names starting with a capital letter. We simply change it to a lower case letter (contracts, interfaces), or append a descriptive prefix (constants, events).
  • removing _ from names. We change shake case to camel case, replace the _ with a prefix if it is a the start of a name (fid for function identifiers, vid for variable identifiers), or entirely remove the _ if it is within all capital letters.
  • make sure that mapping key types are named.

Accordingly, we change the corresponding reference and transactions files and update the rule for the summary of the initial configuration.

@mariaKt mariaKt requested a review from dwightguth September 19, 2024 17:55
@mariaKt mariaKt merged commit 966f3ce into main Sep 19, 2024
1 check passed
@mariaKt mariaKt deleted the update-uniswap branch September 19, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants