Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refined network management #1672

Merged
merged 25 commits into from
Jan 3, 2025
Merged

Refined network management #1672

merged 25 commits into from
Jan 3, 2025

Conversation

crschardt
Copy link
Contributor

This PR implements several refinements to the way that NetworkManager controls the network interface.

  • The monitor detects and logs changes to the network address
  • The monitor detects and logs changes to the connection and will reinitialize the connection if needed
  • Remove NetworkInterface.java class, which wasn't used anywhere
  • Use java.net.NetworkInterface to get IP addresses for any interface (device)
  • Adds a metric for the current IP address (address on the currently selected interface)

@crschardt
add connExists()
5b21e1d
@crschardt
add link-local and update dhcp conn each time its activated
9d233e9
@crschardt
this works
73cc002
@crschardt
Revert "add connExists()"
0bcce11 
This reverts commit 5b21e1d.
@crschardt
remove out-of-place comment
7a90692
@crschardt
wpiformat
0bf9d27
@crschardt
Merge remote-tracking branch 'upstream/master' into enable-link-local…
61bb886 
…-with-dhcp
@crschardt
Merge branch 'master' into enable-link-local-with-dhcp
729af7a
@crschardt
Merge branch 'master' into enable-link-local-with-dhcp
ae11b50
@crschardt
Merge branch 'enable-link-local-with-dhcp' of https://github.com/crsc…
31668bf 
…hardt/photonvision into enable-link-local-with-dhcp
@crschardt
Merge branch 'main' into refined-network-management
6f1d234
@crschardt
refactor and improve interface monitoring
e817bbb
@crschardt
This class isn't used and shadows Java's NetworkInterface class
1e919a3
@crschardt
Methods to find the IP address
ab8aabe
@crschardt
also monitor the active connection
e9479cb
@crschardt
don't log every time we check network
ae82062
@crschardt
show current IP address on settings page
11cc601
@crschardt crschardt requested a review from a team as a code owner January 2, 2025 01:45
@mcm001
Copy link
Contributor

mcm001 commented Jan 2, 2025

Will test on Chris' bench today

mcm001
mcm001 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes smoke test for me anyway

@crschardt crschardt merged commit 474e4f0 into PhotonVision:main Jan 3, 2025
34 checks passed
@crschardt crschardt mentioned this pull request Jan 3, 2025
Merged
crschardt added a commit to PhotonVision/photon-image-modifier that referenced this pull request Jan 4, 2025
@crschardt
Don't wait for online in (#44)
d9bcb56 
With PhotonVision/photonvision#1672, the network
handling is more robust. It should be OK to not wait for NetworkManager
to detect online during the boot process. This will speed bootup,
especially first boot if the system isn't connected to a network.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crschardt @mcm001