Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig file #1457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

EmDash00
Copy link
Contributor

@EmDash00 EmDash00 commented Oct 12, 2024

Added an .editorconfig file. Checked most files to make sure we are (mostly) following these already.

@EmDash00 EmDash00 requested a review from a team as a code owner October 12, 2024 01:38
@crschardt
Copy link
Contributor

crschardt commented Oct 13, 2024

I'm not familiar with .editorconfig and how it interacts with the linters (spotless and wpiformat) that we use. Why do we need this file? Could it cause conflicts with linters if the settings are inconsistent between this file and the linters?

@EmDash00
Copy link
Contributor Author

I'm not familiar with .editorconfig and how it interacts with the linters (spotless and wpiformat) that we use. Why do we need this file? Could it cause conflicts with linters if the settings are inconsistent between this file and the linters?

.editorconfig Doesn't interact with linters or formatters at all. Text editors that support it implement the style settings in the file. For example, if I set my text to default to 4 spaces by default for .java files and it supported Editor Config, it would automatically change it to two spaces for this project. It's not entirely necessary but annoying for people who have different defaults than what is enforced by the formatters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants