Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Add mrcal and camera inspection docs #305

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Jan 4, 2024

No description provided.

@mdurrani808
Copy link
Contributor

Theres a warning on calibration.rst saying that calibration takes a long time at high resolution, does this still home with mrcal? is it more performant

@mcm001
Copy link
Contributor Author

mcm001 commented Jan 4, 2024

It should be faster, but not instant. Pi 4 should be much better than 3, and 5 or a opi5 should blow it out of the water. But it's still worth mentioning that it may take a couple seconds I think?

Also. Someone should try a big chunky (30+ image) dataset on a pi 4 or 5 with mrcal, so we have real numbers

@mdurrani808
Copy link
Contributor

Gotcha lets keep the warning then. One small thing, can you move calibration steps so that calibration tips is the first subsection under tips, and swap calibration w/ PV and calib db.
Small note, you state "Let’s now cd into the calibration folder we created using calibrationUtils.py above" but you should name the section since the investigation section isn't a subsection of the one above it so it doesnt flow well. Otherwise solid.

@mdurrani808 mdurrani808 merged commit 76d5148 into PhotonVision:master Jan 5, 2024
2 checks passed
@mcm001 mcm001 deleted the mrcal branch January 6, 2024 20:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants