Skip to content

Commit

Permalink
Document global.json caveats
Browse files Browse the repository at this point in the history
  • Loading branch information
Phault committed Feb 6, 2024
1 parent ffec535 commit c9164db
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 2 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Changelog

## 0.1.0

#### global.json detection

The plugin will now try to respect any [global.json](https://learn.microsoft.com/en-us/dotnet/core/tools/global-json) it finds,
but it is done in a best effort manner.

proto will always prefer the highest version you allow it, so the `major`, `minor`, `feature` and `patch` options for the `rollForward` field, will instead act like `latestMajor`, `latestMinor`, `latestFeature` and `latestPatch` respectively.

The `allowPrerelease` field is simply ignored. Due to limitations in proto, or rather it's supporting semver library, this would be troublesome to implement in a faithful way. You may still specify a prerelease in the `version` field however, but how this works together with `rollForward` hasn't been tested.

## 0.0.1

#### 🎉 Release
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "dotnet_plugin"
version = "0.0.1"
version = "0.1.0"
edition = "2021"
license = "MIT"
publish = false
Expand Down
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,17 @@ proto install dotnet lts
proto install dotnet 8.0.101
```

## Caveats

### global.json detection

The plugin will try to respect any [global.json](https://learn.microsoft.com/en-us/dotnet/core/tools/global-json) it finds,
but it is done in a best effort manner.

proto will always prefer the highest version you allow it, so the `major`, `minor`, `feature` and `patch` options for the `rollForward` field, will instead act like `latestMajor`, `latestMinor`, `latestFeature` and `latestPatch` respectively.

The `allowPrerelease` field is simply ignored. Due to limitations in proto, or rather it's supporting semver library, this would be troublesome to implement in a faithful way. You may still specify a prerelease in the `version` field however, but how this works together with `rollForward` hasn't been tested.

## Configuration

.NET plugin does not support configuration.
Expand Down

0 comments on commit c9164db

Please sign in to comment.