Skip to content

Add MANIFEST.SKIP file #19523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MANIFEST
Original file line number Diff line number Diff line change
Expand Up @@ -5132,6 +5132,7 @@ Makefile.SH A script that generates Makefile
malloc.c A version of malloc you might not want
malloc_ctl.h A version of malloc you might not want
MANIFEST This list of files
MANIFEST.SKIP Patterns for files not included in this file
mathoms.c A home for binary-compatible code artifacts
META.json Distribution meta-data in JSON
META.yml Distribution meta-data in YAML
Expand Down
6 changes: 6 additions & 0 deletions MANIFEST.SKIP
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
\.mailmap
\.gitignore
\.gitattributes
\.git_patch
^\.git\b
^\.github/
16 changes: 6 additions & 10 deletions Porting/manicheck
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use v5.14;
use warnings;
use File::Find;
use Getopt::Long;
use ExtUtils::Manifest 'maniskip';
use constant SKIP => 125;

my $exitstatus;
Expand All @@ -17,6 +18,7 @@ GetOptions('exitstatus!', \$exitstatus)
my %files;
my $missing = 0;
my $bonus = 0;
my $skip = maniskip;

open my $fh, '<', 'MANIFEST' or die "Can't read MANIFEST: $!\n";
for my $line (<$fh>) {
Expand All @@ -31,17 +33,11 @@ close $fh;
find {
wanted => sub {
return if -d;
return if $_ eq '.mailmap';
return if $_ eq '.gitignore';
return if $_ eq '.gitattributes';
return if $_ eq '.git_patch';

my $x = $File::Find::name =~ s!^\./!!r;
return if $x =~ /^\.git\b/;
return if $x =~ m{^\.github/};
return if $files{$x};
my $path = $File::Find::name =~ s!^\./!!r;
return if $skip->($path);
return if $files{$path};
++$bonus;
print "$x\t\tnot in MANIFEST\n";
print "$path\t\tnot in MANIFEST\n";
},
}, ".";

Expand Down
8 changes: 3 additions & 5 deletions t/porting/manifest.t
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
# correct the problem.

use Config;
use ExtUtils::Manifest 'maniskip';
BEGIN {
@INC = '..' if -f '../TestInit.pm';
}
Expand Down Expand Up @@ -85,14 +86,11 @@ SKIP: {

SKIP: {
find_git_or_skip(6);
my $skip = maniskip;
my %seen; # De-dup ls-files output (can appear more than once)
my @repo= grep {
chomp();
!m{\.git_patch$} &&
!m{\.gitattributes$} &&
!m{\.gitignore$} &&
!m{\.mailmap$} &&
!m{^\.github/} &&
!$skip->($_) &&
-e $_ &&
!$seen{$_}++
} `git ls-files`;
Expand Down