Create ProjectInterfaces.js #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Updated the fork im pulling from, it should update the pull right? |
yeah |
RedMan13
reviewed
May 5, 2025
| arguments: {id: {type: Scratch.ArgumentType.STRING, defaultValue: 'My element'}, dir: {type: Scratch.ArgumentType.NUMBER, defaultValue: 90}} | ||
| },{ | ||
| opcode: "Scale", | ||
| text: "Set scale of ID [id] to wdith: [width]px height: [height]px", |
it didn’t. i’ll try to find out why. |
|
you didn’t commit your changes. |
|
Ok, I actually committed the extension code lmao |
RedMan13
requested changes
May 5, 2025
-Removed console.log calls -Put "lookup" variable in main function -hidden "html attribute" due to xss vulnerabilities
|
@RedMan13 Fixed |
|
theeee xss issue is still applicable |
|
I removed the "Html attribute" block altogether, I searched and discussed with some other members and I couldn't find any other vulnerabilities. (Most of the other ones check to make sure its the right thing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my extension 🥳
let me know (preferably on discord) if there are issues.