Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github repository push access #3405

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Sweetdevil144
Copy link
Contributor

@Sweetdevil144 Sweetdevil144 commented Dec 30, 2024

Description

Fixes #3404
Updated github repository push access to restrict it to pecanProject/pecan only

Motivation and Context

As referenced by @allgandalf in Slack channel, this action should actually be blocked for forked/cloned repos. Restricting it to pecan would help reduce errors

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Abhinav Pandey <[email protected]>
Copy link
Collaborator

@allgandalf allgandalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! , @infotroph any suggestions ?

@infotroph
Copy link
Member

Thanks! I'll test by pushing this to https://github.com/infotroph/pecan-pr-sandbox and seeing if it deploys to https://github.com/infotroph/pecan-documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker.yml Dockerhub Integration
3 participants