Merged
Conversation
dz0ny
force-pushed
the
feat/switch-to-azure-cli-signing
branch
from
7c6bbbd to
8feb869
Compare
🚀 Dev Builds AvailableDevelopment builds for this PR are available in the workflow artifacts. Available builds:
Download the |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release pipeline to sign Windows artifacts via Azure Code Signing (instead of the previous custom VM-based approach), and refreshes the Nix devenv lock inputs.
Changes:
- Switch Windows release signing to
azure/artifact-signing-action@v1and validate signatures viaGet-AuthenticodeSignature. - Remove the manual Azure Win11 VM workflow previously used for temporary signing infrastructure.
- Update
devenv.lockinputs (includingnarHashentries and nixpkgs source wiring).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
devenv.lock |
Updates pinned devenv/nixpkgs-related inputs and adds narHash entries. |
.github/workflows/win-vm.yml |
Removes the manual workflow for starting/reimaging a Windows VM in Azure. |
.github/workflows/release.yml |
Migrates Windows signing to Azure artifact signing and adds signature verification. |
zupo
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/teamniteo/pareto/issues/851