Fix all critical, high, and medium-severity issues for public launch#196
Open
ParamThakkar123 wants to merge 8 commits into
Open
Fix all critical, high, and medium-severity issues for public launch#196ParamThakkar123 wants to merge 8 commits into
ParamThakkar123 wants to merge 8 commits into
Conversation
- Fix DreamerRewardModel/DreamerValueModel lazy export aliases - Fix GenieSmallConfig missing fields (sample_temperature, maskgit_steps) - Fix Genie.from_config() not respecting GenieSmallConfig - Fix DiT.py sinusoidal_time_embedding NameError (cfg.TIMESTEPS removed) - Fix DreamerConfig serialization: list->tuple conversion in from_dict() - Fix observations/__init__.py broken preprocess_obs import - Add weights_only=True to all 18 torch.load() calls - Add allow_pickle=False to all 8 np.load() calls - Add 20 test subdirectory __init__.py files - Convert DreamerConfig to proper @DataClass - Convert DDPM to nn.Module with register_buffer - Add snake_case aliases to DiTConfig via __getattr__/__setattr__ - Move eager imports in benchmarks/runner.py to lazy inside functions - Remove orphaned convae_config.py, mypy_out.txt, .buildinfo.bak - Remove stale pre-commit black hook, clean up .gitignore - Add nuplan dataset implementation with real nuplan-devkit API - Add losses/__init__.py, training/__init__.py expanded exports - Fix CLI --no-random-policy flag, duplicate diamond key, shell=False - Make envs wrappers __getattr__ raise AttributeError - Remove Python 3.9 compat hacks, dead code in rssm/iris_decoder - Replace .cuda() with .to(device) in mdrnn - Set up mypy.ini strict checks - Reduce setup.py to minimal shim with package discovery config - Add runs/ to .gitignore, xfail flaky multiprocessing tests on Windows - Update tox.ini for py311, py312, py313
github-actions
Bot
added
documentation
Contributor
|
… norm_layer types, step unpack, device|str
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 41 audited issues across 6 severity categories in the torchwm codebase to prepare for public launch.
Critical fixes
world_models/reward/__init__.py(lazy exports pointed to non-existent classes)sample_temperatureandmaskgit_stepsfieldsGenieSmallConfigbefore coercing toGenieConfigpreprocess_obsimport with proper exportssinusoidal_time_embeddingNameError(referenced removedcfgvariable)Security fixes
weights_only=Trueto all 18torch.load()calls across 10 filesallow_pickle=True→Falseon all 8np.load()callsHigh-severity
__init__to proper@dataclassnn.Modulewithregister_buffer__getattr__/__setattr____init__.pyfilesmypy.inistrict checksMedium/Infrastructure
nuplan-devkitAPI implementation--no-random-policy, duplicate"diamond"key,shell=Falsesetup.pyreduced to minimal shim with proper package discovery configtox.ininow tests py311/py312/py313xfailTests