feat: can choose privacy when creating a team #11046
Conversation
nickoferrall
changed the title
|
Hey @ackernaut, would you mind reviewing the UI, please? |
| @@ -33,15 +28,16 @@ interface Props { | |||
| const AddTeamDialogViewerFragment = graphql` | |||
| fragment AddTeamDialog_viewer on User { | |||
| ...AdhocTeamMultiSelect_viewer | |||
| organizations { | |||
| organization(orgId: $orgId) { | |||
There was a problem hiding this comment.
Refactored this component to query the org rather than all organizations. This modal only appears in orgTeams which belongs to one org.
I think the component may have originally been used elsewhere for a feature that has since been removed.
Querying one org is more efficient and removes the mutualOrgIds logic which is hard to follow.
There was a problem hiding this comment.
-1 AdhocTeamMultiSelect still selects all orgs and adds completion for users from all orgs. Are we sure we want this behaviour?
There was a problem hiding this comment.
True, I can update this to just query the same org, too
| @@ -133,7 +111,7 @@ const AddTeamDialog = (props: Props) => { | |||
| ) | |||
| } | |||
|
|
|||
| const isValid = selectedUsers.length && teamName.trim() | |||
| const isValid = teamName.trim().length > 0 | |||
There was a problem hiding this comment.
This fixes a bug in prod where you can only create a team if you invite team members. You should be able to create a team just by adding the team name.
|
Yes, I can review! |
|
Thank you! And tagging in Georg to review the code 🙏 |
packages/client/modules/newTeam/components/NewTeamForm/NewTeamForm.tsx
Outdated
Show resolved
Hide resolved
packages/client/modules/newTeam/components/NewTeamForm/NewTeamForm.tsx
Outdated
Show resolved
Hide resolved
packages/client/modules/newTeam/components/NewTeamForm/NewTeamForm.tsx
Outdated
Show resolved
Hide resolved
| @@ -33,15 +28,16 @@ interface Props { | |||
| const AddTeamDialogViewerFragment = graphql` | |||
| fragment AddTeamDialog_viewer on User { | |||
| ...AdhocTeamMultiSelect_viewer | |||
| organizations { | |||
| organization(orgId: $orgId) { | |||
There was a problem hiding this comment.
-1 AdhocTeamMultiSelect still selects all orgs and adds completion for users from all orgs. Are we sure we want this behaviour?
| const [teamNameManuallyEdited, setTeamNameManuallyEdited] = useState(false) | ||
|
|
||
| const MAX_TEAM_NAME_LENGTH = 50 | ||
| const generateTeamName = (newUsers: Option[]) => { |
There was a problem hiding this comment.
The user can enter their team name. This led to confusing behaviour where I'd enter an email address to invite someone to the team and then the team name would be updated to the same name as the email
nickoferrall
requested review from
Dschoordsch
and removed request for
Dschoordsch
|
Thanks @ackernaut ! I'll move these UI updates to a new PR as I know this one is blocking Georg. I've created an issue here and will start work on it now: #11073 |
Fix #11016
When creating a team, users can decide whether the team is public/private.
In org settings, go to teams, and click "Add team" to open this modal:
To test