-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dynamic text for instruction text #10942
Conversation
@iamhks You missed some part of the issue: "retro reflection phase always says it's anonymous" |
Oh yes! I'll keep the text anonymous if that setting is enabled and remove the line if the setting is disabled. |
That would be good. |
Hi @Dschoordsch, please have a look. Updated the screenshots as well. |
FYI: I'll be out of station for about a week and a half, will be able to resolve any comments after I am back. |
Sorry, missed this. Looks good so far, will test tomorrow. |
👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small nit
Description
Fixes #10072
Made code changes to support dynamic text for votes help tool tip & reflections help tool tip
Adding screenshots:
Final checklist