Skip to content

Flatten the Paper development hierarchy #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Flatten the Paper development hierarchy #359

wants to merge 3 commits into from

Conversation

sowelipililimute
Copy link
Contributor

This makes the content more immediately accessible and easier to browse through. Styling has also been adjusted as necessary to accomodate a flatter hierarchy of items; presenting content as a list with headers instead of a grid of cards.

ATM, the hierarchy of other stuff isn't flattened; I can do that if y'all like how it looks on the Paper dev pages.

before after

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/better-listings branch from d0d4315 to fc96bfc Compare April 21, 2024 18:31
zlataovce
zlataovce reviewed Apr 21, 2024
View reviewed changes
olijeffers0n
olijeffers0n requested changes Apr 21, 2024
View reviewed changes
Copy link
Member

@olijeffers0n olijeffers0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the Doc Cards being weird on main admin/dev/contrib pages, I find it weird that the "Welcome to the paper docs" at the top of sidebars have a doc icon as well. Overall, I am a fan of the style though! thanks

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/better-listings branch from fc96bfc to 08edcc8 Compare April 22, 2024 02:35
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/better-listings branch from 08edcc8 to 96a61a4 Compare April 22, 2024 02:37
@sowelipililimute
Copy link
Contributor Author

In addition to the Doc Cards being weird on main admin/dev/contrib pages, I find it weird that the "Welcome to the paper docs" at the top of sidebars have a doc icon as well. Overall, I am a fan of the style though! thanks

fixed this

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/better-listings branch from 96a61a4 to 0ca1ecc Compare April 22, 2024 02:37
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/better-listings branch from 0ca1ecc to 9547695 Compare April 23, 2024 01:39
@olijeffers0n olijeffers0n self-assigned this May 4, 2024
@olijeffers0n olijeffers0n self-requested a review May 4, 2024 12:56
@olijeffers0n olijeffers0n added type: feature New feature or request status: accepted This issue has been accepted labels May 4, 2024
@olijeffers0n
Copy link
Member

Could this be updated? If you are not able to, do not worry.

@sowelipililimute sowelipililimute force-pushed the work/jblackquill/better-listings branch 2 times, most recently from 507955c to 4a4bccd Compare August 3, 2024 15:19
@sowelipililimute
Flatten the development hierarchy
de15a07 
This makes the content more immediately accessible and easier to browse through.
Styling has also been adjusted as necessary to accomodate a flatter hierarchy of items;
presenting content as a list with headers instead of a grid of cards.
@sowelipililimute sowelipililimute force-pushed the work/jblackquill/better-listings branch from 4a4bccd to de15a07 Compare August 12, 2024 03:32
olijeffers0n
olijeffers0n approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@olijeffers0n olijeffers0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a technical and feature POV. Help wanted for if this is better than the current sidebar

@github-actions
Copy link

github-actions bot commented Dec 28, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview c830a3b

@Machine-Maker
Copy link
Member

Looks good. I still want to do the thing where the "Development", "Admin" things are on the top of the page and you change between projects by the logo/project name however.

But this still works with that, making the whole sidebar just development

@zlataovce
Copy link
Member

I'm not sure if the sidebar icons add any value to the navigation experience, it just seems like visual clutter to me; maybe make them a little smaller and darker (to make the page/section names stand out more)?

visual bug when page names are wrapped (icons are shrunk)
image

light mode makes the sidebar icons blend in with the background completely

@zlataovce
Copy link
Member

superseded by #560

@zlataovce zlataovce closed this Apr 19, 2025
sowelipililimute pushed a commit to sowelipililimute/docs that referenced this pull request Sep 7, 2025
@nikthechampiongr
Create maintainer policy on in game permissions (PaperMC#359)
3530b65 
Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zlataovce zlataovce zlataovce left review comments

@olijeffers0n olijeffers0n olijeffers0n approved these changes

Assignees

@olijeffers0n olijeffers0n

Labels

status: accepted This issue has been accepted type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sowelipililimute @olijeffers0n @Machine-Maker @zlataovce