Fix TextColor not treating hue 1.0 the same as 0.0#1368
Open
MartinRedheLind wants to merge 1 commit intoPaperMC:main/5from
Open
Fix TextColor not treating hue 1.0 the same as 0.0#1368MartinRedheLind wants to merge 1 commit intoPaperMC:main/5from
MartinRedheLind wants to merge 1 commit intoPaperMC:main/5from
Conversation
MartinRedheLind
force-pushed
the
fix-hsv
branch
from
f5dda94 to
c742b76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing an HSVLike instance with hue set to 1.0 to TextColor#color returns an incorrect color value with a hue that is off by 60 degrees.
For example:
TextColor.color(HSVLike.hsvLike(1.0f, 1.0f, 0.5f))should yield #7F0000, but actually yields #7F007F.This pr should address the issue.