Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor to apply dry #33

Merged
merged 1 commit into from
Mar 11, 2024
Merged

refactor: refactor to apply dry #33

merged 1 commit into from
Mar 11, 2024

Conversation

pimielowski
Copy link
Contributor

Description

Apply DRY to run main command and few minor changes.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

shinmog
shinmog approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

sebastianczech
sebastianczech approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@sebastianczech sebastianczech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see it's only refactor (this PR does not implement new feature), I propose to use prefix refactor: in PR title.

@pimielowski pimielowski changed the title feat: refactor to apply dry refactor: refactor to apply dry Mar 11, 2024
@pimielowski pimielowski merged commit 5a18280 into main Mar 11, 2024
3 checks passed
@pimielowski pimielowski deleted the feat-refactor-to-dry branch March 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianczech sebastianczech sebastianczech approved these changes

@shinmog shinmog shinmog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pimielowski @sebastianczech @shinmog