chore: Fixed Node Warning and Deprecation Messages #3262
Conversation
WalkthroughThe pull request involves modifications to the Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (2)
package.json (2)
Line range hint
23-23: Restore type definitions for react-chartjs-2 and react-datepickerThe packages
react-chartjs-2andreact-datepickerare present in dependencies but their TypeScript type definitions have been removed. This could cause TypeScript compilation issues.Please restore the following devDependencies:
"devDependencies": { + "@types/react-chartjs-2": "^5.2.0", + "@types/react-datepicker": "^7.5.0", ... }Also applies to: 44-44
Line range hint
164-169: Update React types in resolutions sectionThe resolutions section specifies React types v17.0.2 which conflicts with the project's React v18.3.1. This could lead to type mismatches and incorrect type checking.
Update the resolutions to match the project's React version:
"resolutions": { "@apollo/client": "^3.4.0-beta.19", - "@types/react": "17.0.2", - "@types/react-dom": "17.0.2", + "@types/react": "^18.3.12", + "@types/react-dom": "^18.3.1", "graphql": "^16.5.0" }
🧹 Nitpick comments (1)
package.json (1)
Line range hint
134-138: Align TypeScript-related package versionsThere are version mismatches in TypeScript-related packages:
- @typescript-eslint/eslint-plugin: ^8.11.0
- @typescript-eslint/parser: ^8.5.0
Consider aligning these versions to ensure compatibility and prevent potential issues.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test Application
- GitHub Check: Analyse Code With CodeQL (javascript)
🔇 Additional comments (2)
package.json (2)
171-178: LGTM! Overrides section properly addresses dependency conflictsThe overrides section correctly:
- Forces core-js to v3.40.0 to resolve deprecation warnings
- Aligns rc-color-picker's React dependencies with the project's React version (18.3.1)
- Sets gulp-header to a stable version
Line range hint
134-135: Update ESLint as mentioned in PR objectivesThe PR objectives mention updating ESLint to v9.10.0, but it's currently at v8.49.0.
Please verify if the ESLint update is still needed:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3262 +/- ##
=====================================================
+ Coverage 8.51% 90.27% +81.75%
=====================================================
Files 309 330 +21
Lines 7811 8491 +680
Branches 1730 1875 +145
=====================================================
+ Hits 665 7665 +7000
+ Misses 7072 598 -6474
- Partials 74 228 +154 ☔ View full report in Codecov by Sentry. |
palisadoes
added
the
ignore-sensitive-files-pr
|
Please make a minor commit so that Coderabbit approves |
What kind of change does this PR introduce?
This pr fixes Node Warning and Deprecation Messages When Installing App Packages.
Issue Number:
Fixes #3167
Snapshots/Videos:
Explaination
"overrides": { "rc-color-picker": { "react": "^18.3.1", "react-dom": "^18.3.1" }, },Added rc-color-picker to overrides to resolve peer dependency conflicts. The package normally requires React 16.x, but our project uses React 18.3.1. This override ensures rc-color-picker uses the correct React version, preventing potential compatibility issues and dependency warnings.
Many packages in our dependency chain rely on deprecated versions of their sub-dependencies
Like
"core-js": "^3.40.0"this will enforce all instances of core-js in the dependency tree to use version 3.40.0 and so on.Regarding other depreciated msg
9.10.0Summary by CodeRabbit