Fix: Target AT Translated keyboard for Nitro button and prevent GUI spam#162
Open
VinciyS wants to merge 1 commit into
Open
Fix: Target AT Translated keyboard for Nitro button and prevent GUI spam#162VinciyS wants to merge 1 commit into
VinciyS wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Thıs PR fixes two major issues in the
MapNitroButton.shscript that prevented the Nitro button from launching the application on modern Acer devices (tested on Acer Nitro 16).Root Causes & Fixes:
grep "keyboard\|Keyboard"which often targets external USB receivers or virtual Video Buses instead of the actual motherboard matrix where the Nitro button is hardwired."AT Translated Set 2 keyboard".evtestviasudowhile keeping the rest in user-space. Added apgrepcheck to prevent GUI spamming if the application is already running.Testing:
code 425on the correcteventnode and launches the GUI without duplicate instances.