Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to upgrade Bypass in a project but ran into the issue reported in #122.
Bypass will currently interpret a path as a route by using
Plug.Router.Utils.build_path_match
to split it into path segments.The simplest demonstration of that is by using
/resources/:resource
as both route pattern and path. Theresource
parameter is then supposed to be:resource
but as both are interpreted as route, the parameter ends up being{:resource, [], nil}
. This may not be a problem based on whether the expectation relies on this parameter.However, another scenario is if your path contains multiple colons, e.g.
/resources/a:b:c
. With Bypass' current dependency on Plug 1.10.4, this fails with the following exception:Upgrading Plug to its latest release, version 1.16.1, changes the error but still fails:
Switching the implementation to use
Plug.Router.Utils.split
resolves the issue.