Support ranch 2.1 #148
Open
Support ranch 2.1 #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an attempt to try to support ranch 2.1. I don't have enough time to keep going on this at the moment, so pushing it up in case someone else does - [ ] Implement a Transport module to replace `:socket` in transport opts From the [1.7 -> 2.0 changelog](https://ninenines.eu/docs/en/ranch/2.1/guide/migrating_from_1.7/) > The socket option was removed. A more viable solution is to define a custom transport module that returns a fresh socket when Transport:listen/1 is called. - [ ] Find a way to conditionally send socket opts under a key
|
@davydog187 I tried this too but the issue is that you cannot pass the socket anymore to ranch so Plug.Cowboy fails. Happy to pair, try to find a workaround for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an attempt to try to support ranch 2.1. I don't have enough time to keep going on this at the moment, so pushing it up in case someone else does
:socketin transport optsFrom the 1.7 -> 2.0 changelog
Closes #119