Skip to content

updated jackson dependency #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravishanigarapu merged 16 commits into from
May 30, 2025
Merged

updated jackson dependency #94

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
16dca5c
fix(bug): isNewAbha null issue
May 20, 2025
2159bb0
fix: coderabbit suggestions
May 20, 2025
0d974fc
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty May 23, 2025
ad4cb57
fix: updated ci properties for prod
May 23, 2025
ee53b5a
fix: updated ci properties for abdm
May 23, 2025
c4eeec1
Merge branch 'develop' into develop
helenKaryamsetty May 23, 2025
d4f90d1
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty May 23, 2025
d169521
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty May 30, 2025
97df66f
fix: updated fasterxml jackson dependency to fix scheduler issue
May 30, 2025
d9e9a7d
fix: updated jackson version
May 30, 2025
029baf2
fix: removed versioning for jackson
May 30, 2025
200d8cf
Merge branch 'develop' into develop
helenKaryamsetty May 30, 2025
dd01b9d
fix: Update pom.xml
helenKaryamsetty May 30, 2025
11164d0
fix: modified jackson version for java 8 times
May 30, 2025
67faf11
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty May 30, 2025
d97c69a
Merge branch 'develop' of https://github.com/helenKaryamsetty/FHIR-AP…
May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,12 @@
<version>2.3.0</version>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>2.17.0</version>
</dependency>
Comment on lines +159 to +163
Copy link
Contributor

@coderabbitai coderabbitai bot May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

❓ Verification inconclusive

Ensure Jackson module versions align with Spring Boot BOM

Spring Boot Starter Parent (3.2.2) already manages Jackson versions. Manually adding jackson-datatype-jsr310:2.17.0 may introduce version skew with other Jackson modules (jackson-core, jackson-databind, jackson-annotations) that are BOM-managed.

  • Verify all Jackson artifacts and their versions in your POM:
rg "<artifactId>jackson-" -A1 pom.xml
  • To maintain consistency, either:
  • Remove the explicit <version> so BOM supplies a unified version: 
    <dependency>
  <groupId>com.fasterxml.jackson.datatype</groupId>
  <artifactId>jackson-datatype-jsr310</artifactId>
- <version>2.17.0</version>
</dependency>
  • Or centralize Jackson versions under <dependencyManagement> using a Maven property: 
    <properties>
+ <jackson.version>2.17.0</jackson.version>
</properties>
...
<dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>com.fasterxml.jackson.datatype</groupId>
      <artifactId>jackson-datatype-jsr310</artifactId>
+     <version>${jackson.version}</version>
    </dependency>
  </dependencies>
</dependencyManagement>

This ensures all Jackson modules remain in sync and eases future upgrades.

Align Jackson module versions with Spring Boot BOM

Spring Boot Starter Parent 3.2.2 manages all Jackson dependencies via its BOM. Explicitly pinning jackson-datatype-jsr310 to 2.17.0 can create a version mismatch with jackson-core, jackson-databind, etc. To keep your Jackson modules in sync, remove the manual <version> (or centralize versions under <dependencyManagement>).

• File pom.xml (around lines 159–163):

 <dependency>
   <groupId>com.fasterxml.jackson.datatype</groupId>
   <artifactId>jackson-datatype-jsr310</artifactId>
-  <version>2.17.0</version>
 </dependency>

Optional alternative—centralize Jackson versions:

<properties>
+  <jackson.version>2.17.0</jackson.version>
</properties>

<dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>com.fasterxml.jackson.datatype</groupId>
      <artifactId>jackson-datatype-jsr310</artifactId>
+     <version>${jackson.version}</version>
    </dependency>
  </dependencies>
</dependencyManagement>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>2.17.0</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
</dependency>
🤖 Prompt for AI Agents 
In pom.xml around lines 159 to 163, the jackson-datatype-jsr310 dependency
explicitly specifies version 2.17.0, which may conflict with versions managed by
the Spring Boot Starter Parent BOM 3.2.2. To fix this, remove the <version> tag
from this dependency so the BOM controls the version, ensuring all Jackson
modules remain consistent. Alternatively, centralize Jackson versions under
<dependencyManagement> using Maven properties, but the simplest fix is to omit
the explicit version here.


<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-joda</artifactId>
Expand Down
Loading