Skip to content

Modified jackson dependencies #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravishanigarapu merged 33 commits into from
Jun 6, 2025
Merged

Modified jackson dependencies #104

Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
16dca5c
fix(bug): isNewAbha null issue
May 20, 2025
2159bb0
fix: coderabbit suggestions
May 20, 2025
0d974fc
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty May 23, 2025
ad4cb57
fix: updated ci properties for prod
May 23, 2025
ee53b5a
fix: updated ci properties for abdm
May 23, 2025
c4eeec1
Merge branch 'develop' into develop
helenKaryamsetty May 23, 2025
d4f90d1
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty May 23, 2025
d169521
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty May 30, 2025
97df66f
fix: updated fasterxml jackson dependency to fix scheduler issue
May 30, 2025
d9e9a7d
fix: updated jackson version
May 30, 2025
029baf2
fix: removed versioning for jackson
May 30, 2025
200d8cf
Merge branch 'develop' into develop
helenKaryamsetty May 30, 2025
dd01b9d
fix: Update pom.xml
helenKaryamsetty May 30, 2025
11164d0
fix: modified jackson version for java 8 times
May 30, 2025
67faf11
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty May 30, 2025
d97c69a
Merge branch 'develop' of https://github.com/helenKaryamsetty/FHIR-AP…
May 30, 2025
93ca69e
fix: jackson dependency version removal
May 30, 2025
bcf12d3
Merge branch 'develop' of https://github.com/helenKaryamsetty/FHIR-API
May 30, 2025
c2bb8ff
fix: updated jackson properties
Jun 3, 2025
ede401d
Merge branch 'develop' of https://github.com/helenKaryamsetty/FHIR-AP…
Jun 3, 2025
1e54fa6
fix: update properties
Jun 3, 2025
382de2e
fix: removed jackson dependency completely
Jun 4, 2025
433f837
fix: added hapi base and modified hapi fhir dependency
Jun 4, 2025
f2c9733
Merge branch 'develop' of https://github.com/helenKaryamsetty/FHIR-AP…
Jun 4, 2025
1111177
fix: added all null checks to fhir bundle
Jun 4, 2025
f90f001
Merge branch 'develop' of https://github.com/helenKaryamsetty/FHIR-AP…
Jun 4, 2025
f27d531
fix: missed null checks
Jun 4, 2025
12bc6c2
fix: adding jackson properties
Jun 5, 2025
f0c9d13
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty Jun 5, 2025
bbd8733
fix: jackson versions modification
Jun 6, 2025
6f21692
Merge branch 'develop' of https://github.com/helenKaryamsetty/FHIR-AP…
Jun 6, 2025
203fe09
Merge branch 'PSMRI:develop' into develop
helenKaryamsetty Jun 6, 2025
2c823aa
Merge branch 'develop' of https://github.com/helenKaryamsetty/FHIR-API
Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,22 @@
<artifactId>spring-boot-starter-mail</artifactId>
</dependency>

<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.14.2</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.14.2</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.14.2</version>
</dependency>
Comment on lines +186 to +200
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Uniform Jackson Version Required
The parent Spring Boot BOM already manages Jackson versions. Introducing jackson-core, jackson-databind, and jackson-annotations at explicit 2.14.2 while leaving the other Jackson modules (e.g. jackson-datatype-jsr310 and jackson-datatype-joda) unversioned will result in mismatched Jackson artifacts at build/runtime.

Align all Jackson modules to the same version via the POM’s <dependencyManagement> section and drop direct <version> tags in <dependencies>. For example:

--- pom.xml
@@ <dependencies>
-    <dependency>
-        <groupId>com.fasterxml.jackson.core</groupId>
-        <artifactId>jackson-core</artifactId>
-        <version>2.14.2</version>
-    </dependency>
-    <dependency>
-        <groupId>com.fasterxml.jackson.core</groupId>
-        <artifactId>jackson-databind</artifactId>
-        <version>2.14.2</version>
-    </dependency>
-    <dependency>
-        <groupId>com.fasterxml.jackson.core</groupId>
-        <artifactId>jackson-annotations</artifactId>
-        <version>2.14.2</version>
-    </dependency>
+    <dependency>
+        <groupId>com.fasterxml.jackson.core</groupId>
+        <artifactId>jackson-core</artifactId>
+    </dependency>
+    <dependency>
+        <groupId>com.fasterxml.jackson.core</groupId>
+        <artifactId>jackson-databind</artifactId>
+    </dependency>
+    <dependency>
+        <groupId>com.fasterxml.jackson.core</groupId>
+        <artifactId>jackson-annotations</artifactId>
+    </dependency>
@@
 <dependencyManagement>
     <dependencies>
+        <!-- Override Jackson versions to 2.14.2 -->
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-core</artifactId>
+            <version>2.14.2</version>
+        </dependency>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+            <version>2.14.2</version>
+        </dependency>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-annotations</artifactId>
+            <version>2.14.2</version>
+        </dependency>
     </dependencies>

This ensures all Jackson artifacts remain in sync with the desired version.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.14.2</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.14.2</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.14.2</version>
</dependency>
<!-- Remove explicit Jackson versions here; they’ll be managed below -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
</dependency>
<!-- ... other dependencies ... -->
<dependencyManagement>
<dependencies>
<!-- Override Jackson versions to 2.14.2 -->
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.14.2</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.14.2</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.14.2</version>
</dependency>
</dependencies>
</dependencyManagement>
🤖 Prompt for AI Agents 
In pom.xml between lines 186 and 200, the Jackson dependencies specify explicit
versions (2.14.2) which conflicts with the Spring Boot BOM version management
and causes version mismatches with other Jackson modules. Remove the <version>
tags from these Jackson dependencies and instead manage their versions uniformly
in the <dependencyManagement> section of the POM to ensure all Jackson artifacts
use the same version aligned with Spring Boot BOM.


<!-- https://mvnrepository.com/artifact/ca.uhn.hapi.fhir/hapi-fhir-structures-r4 -->
<dependency>
<groupId>ca.uhn.hapi.fhir</groupId>
Expand Down
Loading