-
Notifications
You must be signed in to change notification settings - Fork 31
Added jackson properties #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the Maven configuration by adding explicit dependencies for Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
β»οΈ Duplicate comments (2)
pom.xml (2)
191-195: Duplicate explicit Jackson version declaration
This mirrors the declaration above forjackson-databind. Apply the same centralized version-management approach as outlined forjackson-core.
196-200: Duplicate explicit Jackson version declaration
Thejackson-annotationsblock follows the same pattern. Consolidate version control per the recommendation at lines 186β190.
π§Ή Nitpick comments (1)
pom.xml (1)
186-190: Prefer leveraging Spring Bootβs dependency management for Jackson
Explicit version declarations forjackson-corecan lead to version drift or conflicts with the parent Spring Boot BOM. Remove the<version>tag and rely on the Spring Boot starterβs managed Jackson version, or, if pinning is required, centralize it in a single<jackson.version>property.
π Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π Files selected for processing (1)
pom.xml(1 hunks)
β° Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (java)
- GitHub Check: Package-test
- GitHub Check: Build
This reverts commit 1637afb.



π Description
JIRA ID: AMM-1452
β Type of Change
βΉοΈ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit