Conversation
cavis
commented
Jan 13, 2026
farski
requested changes
Jan 14, 2026
| StreamRecorderFunctionWarnLevelLogMetricFilter: | ||
| Type: AWS::Logs::MetricFilter | ||
| Properties: | ||
| FilterPattern: '{ $._logLevel = "warn" }' |
Member
There was a problem hiding this comment.
I know there's prior art for these log-level-based alarms, but I always sort of wonder why we don't just emit specific CloudWatch metrics and alarm on those. If things are getting to a point in the code where we are able to decide to log warn vs. error, we probably can equally decide what metric/value to publish, and then these alarms become a lot more meaningful.
Member
Author
There was a problem hiding this comment.
"Emit metrics" meaning... via the aws sdk?
Member
Author
There was a problem hiding this comment.
I guess the downsides are:
- One more dependency to install, permission, and stub out in the tests
- I'd still want the log output anyways, even if we also directly send the CW event
cavis
commented
Jan 14, 2026
farski
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploying the stream-recorder lambda.