Remove CONFIG_INT128 checks from target/ppc/* #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drop VECTOR_FOR_INORDER_I usage since there is no need to access the elements in any particular order, and move the instruction to decodetree.
And also move the insn to decodetree.
And also move the insns to decodetree and remove the now unused avr_qw_addc method.
And also move the insn to decodetree.
And also move the insn to decodetree
And also move the insns to decodetree.
And also move the insn to decodetree and remove the now unused avr_qw_not, avr_qw_cmpu, and avr_qw_add methods.
vcoracolombo
approved these changes
May 30, 2022
alqotel
reviewed
May 31, 2022
Co-authored-by: alqotel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPC-specific methods like
avr_qw_notandavr_qw_addwill hardly ever be tested and require a#ifdef CONFIG_INT128inside each helper that uses them. Instead, we should use int128.h, which is shared with other archs and has unit tests.We also take the opportunity to move some insns to decodetree and drop unnecessary uses of
VECTOR_FOR_INORDER_I.