Testing - Port tc-print functions to PPC64 #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tc-print only uses two functions with arch code specific, which were ported to PPC64 using the internal Decoder. This implementation is still not good to send to facebook, since the target of the branchs are not being dispayed and we need to think in a better architectural solution, since it's using static "if" to switch the code.
|
@lbianc Is there a way to check for the build log that indicates the conflict in question? |
Author
|
@gromero This does not came from the build, the github show the conflict automatically. Not sure if I answered your question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tc-print only uses two functions with arch code specific, which were
ported to PPC64 using the internal Decoder.
This implementation is still not good to send to facebook, since the target
of the branchs are not being dispayed and we need to think in a better
architectural solution, since it's using static "if" to switch the code.