Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show sniff codes in the docs #312

Conversation

przemekhernik
Copy link
Contributor

@przemekhernik przemekhernik commented Jan 28, 2024

No description provided.

@jrfnl
Copy link
Member

jrfnl commented Jan 28, 2024

As per the CONTRIBUTING guide:

Requesting/Submitting New Features

Ideally, start by opening an issue to check whether
the feature is something which is suitable to be included in PHP_CodeSniffer.

It's possible that a feature may be rejected at an early stage, and it's better to find out before you write the code.

It is also good to discuss potential different implementation options ahead of time and get guidance for the preferred option
from the maintainers.

And:

Submitting your pull request

Some guidelines for submitting pull requests (PRs) and improving the chance that your PR will be merged:
...

  • Only open your PR when you've finished work on it, and you are confident that it is ready for review.

I suggest you open an issue to discuss this and close this PR.

@przemekhernik
Copy link
Contributor Author

I'll make you more work than without my engagement here, sorry for this 😅 I'll do this properly as you said :)

@przemekhernik przemekhernik deleted the feature/sniff-codes-in-docs branch May 15, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants