WIP 3d #1100

PhilipDeegan · 2025-11-05T12:13:44Z

not ready, just here for TC tests

coderabbitai · 2025-11-05T12:13:54Z

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)

WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tests/diagnostic/test-diagnostics_3d.cpp

+    electromag_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, allFromPython)


tests/diagnostic/test-diagnostics_3d.cpp

+    particles_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, electromag)


tests/diagnostic/test-diagnostics_3d.cpp

+    fluid_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, particles)


tests/diagnostic/test-diagnostics_3d.cpp

+static std::string const job_file = "job_3d";
+static std::string const out_dir  = "phare_outputs/diags_3d/";
+
+TYPED_TEST(Simulator3dTest, fluid)


tests/diagnostic/test-diagnostics_3d.cpp

+
+#include "core/def/phare_mpi.hpp"
+
+#include "test_diagnostics.ipp"


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp

                auto& J  = hybridModel.state.J;
                auto& Vi = hybridModel.state.ions.velocity();
                auto& Ni = hybridModel.state.ions.chargeDensity();
+                auto& E  = hybridModel.state.electromag.E;


src/amr/data/particles/refine/splitter.hpp

        using FineParticle = decltype(particles[0]); // may be a reference

        core::apply(patterns, [&](auto const& pattern) {
+            auto weight = static_cast<Weight_t>(pattern.weight_);


tests/diagnostic/test-diagnostics_3d.cpp

+    electromag_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, allFromPython)


tests/diagnostic/test-diagnostics_3d.cpp

+    particles_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, electromag)


tests/diagnostic/test-diagnostics_3d.cpp

+    fluid_test(TypeParam{job_file}, out_dir);
+}
+
+TYPED_TEST(Simulator3dTest, particles)


tests/diagnostic/test-diagnostics_3d.cpp

+static std::string const job_file = "job_3d";
+static std::string const out_dir  = "phare_outputs/diags_3d/";
+
+TYPED_TEST(Simulator3dTest, fluid)


tests/diagnostic/test-diagnostics_3d.cpp

src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                        return std::make_tuple(criter_x, criter_y, criter_z);
+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+    {
+        auto const& [start_y, __]
+            = layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
+        auto const& [start_z, ___]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/amr/tagging/default_hybrid_tagger_strategy.hpp

    }
+    if constexpr (dimension == 3)
+    {
+        auto const& [start_y, __]


src/core/numerics/pusher/fusher.hpp

+// #include "core/utilities/range/range.hpp"
+// #include "core/data/particles/particle.hpp"


src/core/numerics/pusher/fusher.hpp

src/amr/tagging/default_hybrid_tagger_strategy.hpp

+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);
+                    auto const& [Bz_x, Bz_y, Bz_z] = field_diff(Bz);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);
+                    auto const& [Bz_x, Bz_y, Bz_z] = field_diff(Bz);


src/amr/tagging/default_hybrid_tagger_strategy.hpp

+                    };
+
+                    auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);
+                    auto const& [By_x, By_y, By_z] = field_diff(By);


src/core/data/grid/gridlayout.hpp

tests/diagnostic/test-diagnostics_3d.cpp

+
+#include "core/def/phare_mpi.hpp"
+
+#include "test_diagnostics.ipp"


tests/diagnostic/test-diagnostics_3d.cpp

+
+#include "core/def/phare_mpi.hpp"
+
+#include "test_diagnostics.ipp"


src/diagnostic/detail/vtkh5_type_writer.hpp

+template<typename Writer>
+class H5TypeWriter : public PHARE::diagnostic::TypeWriter
+{
+    using FloatType                      = float; // Writer::FloatType;


src/core/utilities/algorithm.hpp

+    auto const& layout            //
+)
+{
+    bool static constexpr c_ordering = false;


src/core/utilities/algorithm.hpp

+    auto const& layout            //
+)
+{
+    bool static constexpr c_ordering = false;


src/diagnostic/detail/vtkh5_type_writer.hpp

PhilipDeegan marked this pull request as draft November 5, 2025 12:13

github-advanced-security bot found potential problems Nov 5, 2025

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from e1b7238 to 4de43d2 Compare November 7, 2025 15:11

github-advanced-security bot found potential problems Nov 7, 2025

View reviewed changes

src/core/numerics/pusher/fusher.hpp Outdated

Comment on lines 9 to 10

// #include "core/utilities/range/range.hpp"

// #include "core/data/particles/particle.hpp"

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.

github-advanced-security bot found potential problems Nov 7, 2025

View reviewed changes

src/core/numerics/pusher/fusher.hpp Fixed Show fixed Hide fixed

PhilipDeegan force-pushed the 3d_new branch from 4de43d2 to f525884 Compare November 7, 2025 21:20

PhilipDeegan mentioned this pull request Nov 8, 2025

Update to 3D #960

Draft

PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from 08883a9 to d04e167 Compare November 10, 2025 12:55

github-advanced-security bot found potential problems Nov 10, 2025

View reviewed changes

PhilipDeegan force-pushed the 3d_new branch 14 times, most recently from 76f6bfb to be02045 Compare November 11, 2025 16:42

github-advanced-security bot found potential problems Nov 12, 2025

View reviewed changes

src/core/data/grid/gridlayout.hpp Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Nov 12, 2025

View reviewed changes

src/core/data/grid/gridlayout.hpp Outdated Show resolved Hide resolved

PhilipDeegan force-pushed the 3d_new branch 9 times, most recently from c7354fb to e7507ab Compare November 13, 2025 19:13

github-advanced-security bot found potential problems Nov 13, 2025

View reviewed changes

tests/diagnostic/test-diagnostics_3d.cpp

#include "core/def/phare_mpi.hpp"

#include "test_diagnostics.ipp"

Check notice

Code scanning / CodeQL

Include header files only

The #include pre-processor directive should only be used to include header files.

github-advanced-security bot found potential problems Nov 13, 2025

View reviewed changes

tests/diagnostic/test-diagnostics_3d.cpp

#include "core/def/phare_mpi.hpp"

#include "test_diagnostics.ipp"

Check notice

Code scanning / CodeQL

Include header files only Note test

The #include pre-processor directive should only be used to include header files.

PhilipDeegan force-pushed the 3d_new branch from e7507ab to efba3e0 Compare November 17, 2025 14:58

github-advanced-security bot found potential problems Nov 17, 2025

View reviewed changes

src/core/utilities/algorithm.hpp

auto const& layout //

)

{

bool static constexpr c_ordering = false;

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable c_ordering is not used.

src/diagnostic/detail/vtkh5_type_writer.hpp Fixed Show fixed Hide fixed

PhilipDeegan force-pushed the 3d_new branch 4 times, most recently from 6b45d10 to f37b2c4 Compare November 19, 2025 10:29

vtkhdf

caa898e

PhilipDeegan force-pushed the 3d_new branch from f37b2c4 to 10ba260 Compare November 19, 2025 12:14

PhilipDeegan mentioned this pull request Nov 19, 2025

Vtk hdf #1084

Open

PhilipDeegan added 2 commits November 19, 2025 19:51

wippolatta

0cc4fd2

3d

dbbfb08

PhilipDeegan force-pushed the 3d_new branch from 1f05cfc to dbbfb08 Compare November 20, 2025 09:23

timings

2fff841


		#include "core/def/phare_mpi.hpp"

		#include "test_diagnostics.ipp"

		// #include "core/utilities/range/range.hpp"
		// #include "core/data/particles/particle.hpp"

WIP 3d #1100

Are you sure you want to change the base?

WIP 3d #1100

Uh oh!

Conversation

PhilipDeegan commented Nov 5, 2025

Uh oh!

coderabbitai bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Check notice

Check notice

Check notice

Check notice

Uh oh!

Uh oh!

Check notice

Check notice

Check notice

Check notice

Check notice

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Nov 5, 2025 •

edited

Loading