set mag ghosts on regrid #1033
set mag ghosts on regrid #1033
Conversation
📝 WalkthroughWalkthroughA call to fill magnetic patch ghost data was added at the end of the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant HybridHybridMessengerStrategy
participant magPatchGhostsRefineSchedules
Caller->>HybridHybridMessengerStrategy: regrid(levelNumber, ...)
HybridHybridMessengerStrategy->>HybridHybridMessengerStrategy: Perform regridding
HybridHybridMessengerStrategy->>HybridHybridMessengerStrategy: Refine particles
HybridHybridMessengerStrategy->>magPatchGhostsRefineSchedules: fillData(initDataTime)
magPatchGhostsRefineSchedules-->>HybridHybridMessengerStrategy: (ghost data filled)
HybridHybridMessengerStrategy-->>Caller: return
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp (1)
301-301: Remove unnecessary empty line.The empty line before the new magnetic ghost filling call is unnecessary and should be removed for cleaner code formatting.
- magPatchGhostsRefineSchedules[levelNumber]->fillData(initDataTime);
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.hpp`: Review the C++ code, point out issues relative to principles of clean code, expressiveness, and performance.
**/*.hpp: Review the C++ code, point out issues relative to principles of clean code, expressiveness, and performance.
⚙️ Source: CodeRabbit Configuration File
List of files the instruction was applied to:
src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp
🧠 Learnings (1)
📓 Common learnings
Learnt from: PhilipDeegan
PR: PHAREHUB/PHARE#888
File: pyphare/pyphare/pharesee/hierarchy/hierarchy_utils.py:566-568
Timestamp: 2024-09-09T13:57:02.285Z
Learning: Avoid commenting on draft PRs for PhilipDeegan unless explicitly requested.
Learnt from: PhilipDeegan
PR: PHAREHUB/PHARE#888
File: src/hdf5/detail/h5/h5_file.hpp:78-79
Timestamp: 2024-09-05T17:02:58.784Z
Learning: Avoid commenting on draft PRs for the user PhilipDeegan.
Learnt from: PhilipDeegan
PR: PHAREHUB/PHARE#888
File: src/hdf5/detail/h5/h5_file.hpp:78-79
Timestamp: 2024-10-09T08:32:15.667Z
Learning: Avoid commenting on draft PRs for the user PhilipDeegan.
Learnt from: PhilipDeegan
PR: PHAREHUB/PHARE#784
File: tests/simulator/test_restarts.py:333-339
Timestamp: 2024-07-26T22:04:34.160Z
Learning: PhilipDeegan has indicated a preference for minimal and efficient code, even after making changes to get a function working. There may be opportunities to remove or optimize parts of the code such as sleep/wait/advances.
Learnt from: PhilipDeegan
PR: PHAREHUB/PHARE#784
File: tests/simulator/test_restarts.py:333-339
Timestamp: 2024-10-09T08:32:15.667Z
Learning: PhilipDeegan has indicated a preference for minimal and efficient code, even after making changes to get a function working. There may be opportunities to remove or optimize parts of the code such as sleep/wait/advances.
🧬 Code Graph Analysis (1)
src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp (2)
src/amr/messengers/refiner.hpp (2)
levelNumber(152-159)levelNumber(152-152)src/amr/messengers/refiner_pool.hpp (2)
levelNumber(107-113)levelNumber(107-107)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Analyze (cpp)
- GitHub Check: Analyze (python)
- GitHub Check: build (ubuntu-latest, gcc)
- GitHub Check: build (macos-13)
- GitHub Check: build (macos-14)
- GitHub Check: build (ubuntu-latest, clang)
🔇 Additional comments (1)
src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp (1)
302-302: LGTM! Proper addition of magnetic ghost filling after regrid.The addition of magnetic patch ghost data filling at the end of the regrid method is correct and follows the existing pattern used in
postSynchronize(line 658). This ensures magnetic field ghost data consistency after regridding operations.
|
This PR is adding filling of magnetic patch ghosts after regridding. |
2 participants
pr in isolation to confirm no side affects