Adopt virtual components #1494
Open
Adopt virtual components #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cswhite2000
previously approved these changes
Feb 18, 2025
|
Seems there's a build failure |
Signed-off-by: Pablo Herrera <[email protected]>
Pablete1234
force-pushed
the
adopt-virtual-components
branch
from
ac77411 to
2d7b9d3
Compare
|
build fails due to using a snapshot adventure build, we can wait until they release to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PGM had a
RenderableComponentthat extended from component directly, and implemented custom logic to be rendered per-player. Adventure has finally added virtual components which allow us to do the same in a less hacky way, since we no longer need to extend the api, we can just use the virtual component api instead.