Skip to content

Conversation

TJnotJT
Copy link
Contributor

@TJnotJT TJnotJT commented Oct 10, 2025

Draft until fully tested.

Description of Changes

  1. Vertex kick: Ensure line/point rounding and AA are accounted for in the degenerate primitive test.
  2. SW: Apply the same degenerate primitive test fix as vertex kick.
  3. Simplify primitive bounding box and scissor calculations in vertex kick.
  4. SW: Minor optimization for horizontal lines in the rasterizer.

Rationale behind Changes

Some edge cases cause the degenerate primitive test to incorrectly pass or fail primitives, especially when antialiasing is enabled. This can result in issues such as #8677. These changes should fix that issue and address additional minor problems discussed in #13297.

Suggested Testing Steps

This update will affect any GS drawing, so testing games with both HW/SW under different options will be helpful. This should not affect performance much, so only accuracy needs to be checked.

Did you use AI to help find, test, or implement this issue or feature?

Copilot occasionaly for code completion.

@TJnotJT TJnotJT marked this pull request as draft October 10, 2025 21:58
@bigol83
Copy link

bigol83 commented Oct 10, 2025

God of War and God of War 2 fixed

immagine immagine

🎉

@James-F2
Copy link

WOW, what an improvement!
Thank you!

@James-F2
Copy link

Possibly the outline of the character here too:

DBZ BT 3.zip

@refractionpcsx2
Copy link
Member

Possibly the outline of the character here too:

DBZ BT 3.zip

That's pre rounding solved by the preround pr (when it's finally done right)

@James-F2
Copy link

James-F2 commented Oct 13, 2025

HW (Vulkan) and Internal Resolution on "Native (PS2)" still bugged.

God of War_SCUS-97399_20251013142600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants