-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
GS: Allow dumping draw/frames stats. #13352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
892a978
to
f05905d
Compare
pcsx2/GS/GSUtil.cpp
Outdated
"Unswizzle", | ||
"Fillrate", | ||
"SyncPoint", | ||
"Barriers", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need barrier info for sw?
f05905d
to
16fbcab
Compare
Updated GSUtil arrays to reflects that SW renderer does not track barriers or render passes. Also removed the "CounterLast" string from both HW and SW arrays. |
16fbcab
to
a045fc4
Compare
Small fix: The barrier/render pass stats were still being dumped for SW--removed that also. |
a045fc4
to
9467e9a
Compare
There was a typo causing an out of bounds exception in the previous change. Fixed it and checked to make sure it's running correctly. |
"DrawCalls", | ||
"Readbacks", | ||
"Swizzle", | ||
"Unswizzle", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the swizzle/unswizzle stuff relevant to sw as well?
pcsx2/GS/GSPerfMon.cpp
Outdated
std::size_t last = hw ? CounterLastHW : CounterLastSW; | ||
for (std::size_t i = 0; i < last; i++) | ||
{ | ||
fprintf(fp, "%s: %I64u\n", GSUtil::GetPerfMonCounterName(static_cast<counter_t>(i), hw), static_cast<u64>(m_counters[i])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%I64u is a Microsoft extension.
You can either use PRIu64
or %llu
with a cast to unsigned long long
.
9467e9a
to
51686e9
Compare
51686e9
to
1811144
Compare
Description of Changes
Adds support for dumping per-draw and per-frame stats.
Known issues:
This is mainly a debug tool, so the current behavior is suitable for comparing branches.
Rationale
Makes it easier to compare branches and identify the draw or frame where stats start to differ.
Testing Steps
Example output:
AI Assistance
Yes, to draft this message.