-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Debugger: Rename debugger widgets to views and update UI layout format #12440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18a0ec3
to
91e6840
Compare
7aa1d08
to
a2ccf02
Compare
a2ccf02
to
378ca04
Compare
Ready for review now. I've changed it quite a lot. |
2c55590
to
6594884
Compare
6594884
to
d038f4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this on Linux and things look good. Debugger and layouts seem to work as expected. Only thing I noticed when looking at the diff was that you didn't rename |
That's okay, it's not like the others. |
Would this cause more work for translators? Like, would we need to batch change the translations to match the new type names somehow too? I'm not sure how that would work. |
I barely know anything about the translation stuff but... I ran |
It's automatically managed by cron jobs. Don't worry about it. |
Description of Changes
The DebuggerWidget class has been renamed to DebuggerView. All subclasses have also been renamed.
This makes three changes to the format:
I've also fixed a bug where the UI layouts may have been saved unnecessarily after loading them.
Rationale behind Changes
Suggested Testing Steps