Debugger: Memory search changes #12278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F0bes
force-pushed
the
dbg-unknown-value
branch
from
65f9948 to
99eb31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds an 'unknown initial value' comparison to the memory searcher (fixes #12276)
Made it so we only validate the search value input when the comparison uses the value.
Rationale behind Changes
Better ergonomics and improves the utility of the debugger.
Suggested Testing Steps
Try doing a filter search with 'decreased by', 'unchanged', etc with the search value text-box being empty
Try filtering down a value using the 'unknown initial value' comparison.