refactor(sounds): simplify alert sounds by severity#679
Merged
Conversation
Keep alert sound selection focused on provider severity and preserve compatibility for older packs and muted settings. Constraint: existing sound packs and saved muted-event settings must keep loading safely Rejected: exact alert text and hazard/type fallback mapping | it kept a brittle user-facing taxonomy that no longer matches the provider surface Confidence: high Scope-risk: moderate Directive: keep new alert sounds severity-first; preserve legacy keys only as hidden compatibility Tested: pytest tests/test_settings_dialog_audio_events.py tests/test_alert_sound_mapper.py tests/test_sound_player.py::TestGetSoundEntry::test_get_sound_entry_for_candidates_falls_back_within_pack tests/test_sound_player.py::TestUserLevelMute tests/test_soundpack_event_catalog.py -q; pytest tests/test_alert_notification_system.py tests/test_toasted_windows_notifier.py::TestToastedWindowsNotifierSend::test_send_uses_sound_candidates_when_provided -q; ruff check targeted files; ruff format --check targeted files; pyright; git diff --check Not-tested: manual audio playback through the desktop UI Co-authored-by: OmX <omx@oh-my-codex.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Manual testing