This repository was archived by the owner on Jun 3, 2021. It is now read-only.
Route53 updater#945
Merged
Merged
Conversation
added 17 commits
December 29, 2017 17:17
charlierudolph
approved these changes
Jan 5, 2018
Contributor
charlierudolph
left a comment
charlierudolph
left a comment
There was a problem hiding this comment.
Looks great to me. I added in #946 so we can add some documentation for how to use this. Please wait for a review from @alexdavid
|
|
||
| func main() { | ||
| if len(os.Args) < 3 { | ||
| panic(errors.New("Not enough arguments. Arguments must be non-empty strings passed into 'route53-updater <service-role> <internal-hosted-zone-name>'")) |
Contributor
There was a problem hiding this comment.
Lets use log.Fataln instead of panic as we don't need to have the stack trace printed
| ) | ||
|
|
||
| func main() { | ||
| if len(os.Args) < 3 { |
Contributor
There was a problem hiding this comment.
How about checking if len(os.Args) != 3?
alexdavid
approved these changes
Jan 5, 2018
| "ecs:StartTask", | ||
| "autoscaling:*" | ||
| "autoscaling:*", | ||
| "route53:ChangeResourceRecordSets", |
Contributor
There was a problem hiding this comment.
I think we should restrict this to only allow changes on the internal hosted zone
Contributor
Author
There was a problem hiding this comment.
How would we restrict it to only the internal hosted zone in aim roles?
| if serviceRole == "" || internalHostedZoneName == "" { | ||
| log.Fatalln(errors.New("Service role or internal hosted zone name missing. Both arguments must be non-empty strings passed into 'route53-updater <service-role> <internal-hosted-zone-name>'")) | ||
| } | ||
| internalIP, err := exec.Command("curl", "-fsSL", "http://169.254.169.254/latest/meta-data/local-ipv4").Output() |
Contributor
There was a problem hiding this comment.
does it make sense to run this as an external command or just make an http request here?
added 4 commits
January 8, 2018 14:21
hugoesthere
pushed a commit
that referenced
this pull request
Jan 9, 2018
* expose worker ports in local development * address comments * Route53 updater (#945) * address comments * test * update * update * update * update * update * update * update * update * update * update * update * update * update * update * update * address comments * service endpoints * http call * restrict policy to internal zones * move policy * update * update * change resource * address comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #869
See: Originate/space-tweet#43 for an example
Tested and works:
