Skip to content

Conversation

@sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Jan 6, 2026

This PR fixes an issue where a failed withdrawal on the Remote strategy didn't get processed on the master strategy. As the master was rejecting any balanceCheck messages that didn't arrive with USDC tokens transferred.

To fix the issue this PR adds an additional transferConfirmation parameter to balanceCheck indicating whether it is part of the withdrawal / deposit process. This simplifies the logic since different conditions can all be handled within the _processBalanceCheckMessage function.

Related resources:

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.85%. Comparing base (77cd4e5) to head (c89cd09).
⚠️ Report is 2 commits behind head on shah/cross-chain-strategy-cctpv2.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           shah/cross-chain-strategy-cctpv2    #2733      +/-   ##
====================================================================
+ Coverage                             41.66%   41.85%   +0.19%     
====================================================================
  Files                                   133      133              
  Lines                                  6128     6124       -4     
  Branches                               1632     1631       -1     
====================================================================
+ Hits                                   2553     2563      +10     
+ Misses                                 3572     3557      -15     
- Partials                                  3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahthepro shahthepro merged commit a17cd0a into shah/cross-chain-strategy-cctpv2 Jan 7, 2026
10 of 17 checks passed
@shahthepro shahthepro deleted the sparrowDom/cross-chain-strategy-race-condition branch January 7, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants