add a test that uncovers a withdrawal error #2733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a failed withdrawal on the Remote strategy didn't get processed on the master strategy. As the master was rejecting any balanceCheck messages that didn't arrive with USDC tokens transferred.
To fix the issue this PR adds an additional
transferConfirmationparameter to balanceCheck indicating whether it is part of the withdrawal / deposit process. This simplifies the logic since different conditions can all be handled within the_processBalanceCheckMessagefunction.Related resources: