Skip to content

Google Ads v23#133

Merged
Lewis-Clayton merged 2 commits intomasterfrom
google-ads-v23
Jan 30, 2026
Merged

Google Ads v23#133
Lewis-Clayton merged 2 commits intomasterfrom
google-ads-v23

Conversation

@Lewis-Clayton
Copy link
Contributor

@Lewis-Clayton Lewis-Clayton commented Jan 29, 2026

Summary

  • Upgrade from Google Ads API v22 to v23
  • Update proto definitions, generated TypeScript clients, and samples
  • Update dependencies (gapic-tools, google-gax, etc.)
  • Bump package version to 23.0.0-beta.0 for testing
  • Aligned versioning to Google Ads API

Test plan

  • npm test passes
  • Test beta package in downstream project (google-ads-api)
  • Update version to 23.0.0 after review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25bfb71915

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{
"name": "google-ads-node",
"version": "18.0.0",
"version": "19.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align package-lock version with package.json

The root lockfile still records the package version as 19.0.0 here, while package.json declares 20.0.0-beta.0 (see package.json line 3). When running installs or release tooling that validates lockfile consistency, this mismatch indicates a stale lockfile and will typically trigger an update or failure, leading to non‑reproducible or dirty builds for anyone installing dependencies. Please regenerate the lockfile so both files agree.

Useful? React with 👍 / 👎.

@Lewis-Clayton Lewis-Clayton merged commit c44ef40 into master Jan 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants