Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(everything): replace Greek 'μ' with micro 'µ' #17331

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from
Open

Conversation

ddcc4
Copy link
Contributor

@ddcc4 ddcc4 commented Jan 22, 2025

Overview

There are two different characters that look like the "mu" symbol:

  • µ (U+00B5 MICRO SIGN)
  • μ (U+03BC GREEK SMALL LETTER MU)

In some fonts they look different; but in many fonts they look the same.

The problem is that in the Public Sans font that we use for Protocol Designer, U+03BC GREEK SMALL LETTER MU is not available at all, because the font only supports Latin characters plus some scientific symbols. So whenever we use U+03BC GREEK SMALL LETTER MU in text, the browser has to render it with a fallback font, which can look ugly.

For consistency, we should just use U+00B5 MICRO SIGN whenever we have a µ that means 1/1,000,000, and only use U+03BC GREEK SMALL LETTER MU when we're writing Greek text (like in a Greek-language user manual).

Test Plan and Hands on Testing

I did a global search and replace on all the text in our codebase. I'm relying on the CI tests to catch any issues.

Risk assessment

This could potentially break external dependencies that expect the Greek-text mu.

@ddcc4 ddcc4 requested review from a team as code owners January 22, 2025 21:27
@ddcc4 ddcc4 requested review from ncdiehl11 and removed request for a team January 22, 2025 21:27
@jwwojak
Copy link
Contributor

jwwojak commented Jan 22, 2025

I think microliter should be abbreviated as "µL" not "µl" (use capital L). I know our API docs are inconsistent here. All our text and online manuals use µL.

@ddcc4
Copy link
Contributor Author

ddcc4 commented Jan 22, 2025

I think microliter should be abbreviated as "µL" not "µl" (use capital L). I know our API docs are inconsistent here. All our text and online manuals use µL.

Agreed! µL is the correct SI abbreviation. But I want PR's to only do one thing at a time, so editorial changes like µl -> µL should go into a separate PR.

@ddcc4 ddcc4 requested a review from koji January 22, 2025 21:52
@mjhuff
Copy link
Contributor

mjhuff commented Jan 22, 2025

Apologies for the failing components CI, I'll put a fix up!

EDIT: Fix merged into edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants