fix(shared-data): Add back missing parent labwares for auto sealing lids #17195
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjoel42
approved these changes
Jan 7, 2025
CaseyBatten
deleted the
inclusion-of-missing-labware-parents-for-auto-sealing-lid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Covers RQA-3819
With the improved lid architecture labware definitions we need to provide compatible parent labwares rather than generally accepting any labware as a potential parent. Some were missed when updating the auto-sealing lids definition, leading to this bug being found.
Test Plan and Hands on Testing
Changelog
Review requests
Question for reviewers: Should we just ignore a parent "labware" all together if it's an adapter when checking the "compatible parent labwares" list? Would that cause us a headache later?
Risk assessment
Low - enforces existing 8.2 behavior.