Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): Make createNew.ts more robust and use it to start testing protocol actions in PD #17156

Open
wants to merge 40 commits into
base: edge
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
d83c729
I made a robotSelection() function added to commands.ts. Next commit …
alexjoel42 Dec 13, 2024
6b7eff3
you can now select pipettes
alexjoel42 Dec 16, 2024
6e40698
Merge branch 'edge' into E2E_Transfer_and_Command_update
alexjoel42 Dec 16, 2024
df1942d
I moved the base url to be the sandbox instead of local host. This wa…
alexjoel42 Dec 16, 2024
5e9e55d
updated url to 8.2.2 so we can plan for the confirmation modal
alexjoel42 Dec 16, 2024
2950726
refactoring for 8.2.0
alexjoel42 Dec 16, 2024
f156954
very small change to make JS checker happier
alexjoel42 Dec 16, 2024
f40e60e
fixed the protocols using our little pop up.
alexjoel42 Dec 17, 2024
50c6836
just added some functions to get us closer to transfer step 5 woo
alexjoel42 Dec 17, 2024
6300eaa
move baseurl and made deck selector
alexjoel42 Dec 18, 2024
2ccb2de
local host not updated yet
alexjoel42 Dec 18, 2024
13e762c
I changed chose deck slot to just return the deck slot. ToDo is to ma…
alexjoel42 Dec 19, 2024
391d04c
done
alexjoel42 Dec 19, 2024
5b7e02e
Merge branch 'edge' into E2E_Transfer_and_Command_update
alexjoel42 Dec 19, 2024
8750068
we did it! It's prettier
alexjoel42 Dec 19, 2024
8259eec
refactored and linted all tests
alexjoel42 Dec 19, 2024
ae5b69c
Merge branch 'edge' into E2E_Transfer_and_Command_update
alexjoel42 Dec 19, 2024
29903d3
formatting fixed in a few places with prettier
alexjoel42 Dec 19, 2024
f402fa5
hope this updates
alexjoel42 Dec 19, 2024
0a5c1c6
another commit to finally fix the deck slot function
alexjoel42 Dec 19, 2024
d7fb3d2
small steps
alexjoel42 Dec 19, 2024
2d35674
Did some prettier changes and am starting to move commands into creat…
alexjoel42 Dec 20, 2024
203d2bc
Made a new file createNewFlex.cy.ts this will be where I translate my…
alexjoel42 Dec 20, 2024
fcd9fb7
Almost done with gripper. Moving onto modules
alexjoel42 Dec 20, 2024
0b03395
Check NewFlex.cy.ts I am almost there
alexjoel42 Dec 21, 2024
2594d63
added closing analytics and selecting deck slots
alexjoel42 Dec 23, 2024
68acf18
addressed the close analytics button
alexjoel42 Dec 23, 2024
1af99d6
addresses comments
alexjoel42 Dec 23, 2024
6dea456
close analytics modal to edit protocol
alexjoel42 Dec 23, 2024
8739044
I have remodeled the transferSetting.cy.js page and will build on it …
alexjoel42 Dec 23, 2024
1f4e8d6
I think this should work! No typescript errors
alexjoel42 Dec 24, 2024
b0dffda
fixed the deck selection function I think
alexjoel42 Dec 24, 2024
9b6852d
last commit before vacation
alexjoel42 Dec 24, 2024
e9488ef
Merge branch 'edge' into E2E_Transfer_and_Command_update
alexjoel42 Dec 25, 2024
fda19a0
updating and taking in Koji's comments
alexjoel42 Dec 25, 2024
8844728
change mix settings to ts
alexjoel42 Jan 2, 2025
b54dbad
we are holding on createNew right now so that I can unblock Sara if p…
alexjoel42 Jan 2, 2025
50e0774
finally passes lint
alexjoel42 Jan 2, 2025
f9592a5
Wow, did not realize I broke my tests
alexjoel42 Jan 2, 2025
e60771b
Merge branch 'edge' into E2E_Transfer_and_Command_update
alexjoel42 Jan 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol-designer/cypress/e2e/createNew.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ import { UniversalActions } from '../support/universalActions'
describe('The Redesigned Create Protocol Landing Page', () => {
beforeEach(() => {
cy.visit('/')
cy.contains('button', 'Confirm').click()
alexjoel42 marked this conversation as resolved.
Show resolved Hide resolved
})

it('content and step 1 flow works', () => {
cy.closeAnalyticsModal()
cy.clickCreateNew()
cy.verifyCreateNewHeader()
verifyCreateProtocolPage()
Expand Down
4 changes: 3 additions & 1 deletion protocol-designer/cypress/e2e/import.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,19 @@ import {
describe('The Import Page', () => {
beforeEach(() => {
cy.visit('/')
cy.closeAnalyticsModal()

})

it('successfully loads a protocol exported on a previous version', () => {
cy.contains('button', 'Confirm').click()
alexjoel42 marked this conversation as resolved.
Show resolved Hide resolved
const protocol = getTestFile(TestFilePath.DoItAllV7)
cy.importProtocol(protocol.path)
verifyOldProtocolModal()
verifyImportProtocolPage(protocol)
})

it('successfully loads a protocol exported on the current version', () => {
cy.contains('button', 'Confirm').click()
alexjoel42 marked this conversation as resolved.
Show resolved Hide resolved
const protocol = getTestFile(TestFilePath.DoItAllV8)
cy.importProtocol(protocol.path)
verifyImportProtocolPage(protocol)
Expand Down
4 changes: 3 additions & 1 deletion protocol-designer/cypress/e2e/migrations.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import { TestFilePath } from '../support/testFiles'
describe('Protocol fixtures migrate and match snapshots', () => {
beforeEach(() => {
cy.visit('/')
cy.closeAnalyticsModal()
// Get rid of the analytics
cy.contains('button', 'Confirm').click()
alexjoel42 marked this conversation as resolved.
Show resolved Hide resolved

})

const testCases: MigrateTestCase[] = [
Expand Down
2 changes: 1 addition & 1 deletion protocol-designer/cypress/e2e/settings.cy.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
describe('The Settings Page', () => {
before(() => {
cy.visit('/')
cy.closeAnalyticsModal()
cy.contains('button', 'Confirm').click()
alexjoel42 marked this conversation as resolved.
Show resolved Hide resolved
})

it('content and toggle state', () => {
Expand Down
Loading
Loading