feat(hardware-testing): add testing teams feature requests #15652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Jul 15, 2024
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: https://github.com/Opentrons/opentrons/pull/ |
ryanthecoder
force-pushed
the
hw-testing-final-fixes-for-lld
branch
2 times, most recently
from
eb22ce6 to
2ff2cc6
Compare
pmoegenburg
previously requested changes
Jul 16, 2024
| @@ -188,7 +188,7 @@ async def liquid_probe_in_place( | |||
| pipette_id=pipette_id | |||
| ) | |||
| z_pos = await self._hardware_api.liquid_probe( | |||
| mount=hw_pipette.mount, max_z_dist=well_depth - lld_min_height | |||
| mount=hw_pipette.mount, max_z_dist=well_depth - lld_min_height + 2 | |||
There was a problem hiding this comment.
Can we make this method take a well_location and use the well_location.offset.z instead of the magic number 2 here?
| @@ -2666,6 +2666,8 @@ async def liquid_probe( | |||
| except PipetteLiquidNotFoundError as lnfe: | |||
| error = lnfe | |||
| pos = await self.gantry_position(checked_mount, refresh=True) | |||
| await self.move_to(checked_mount, probe_start_pos + top_types.Point(z=2)) | |||
There was a problem hiding this comment.
This can just be a move to probe_start_pos, and then line 2671 can be removed
There was a problem hiding this comment.
Cant actually physically, this 2 is a different magic 2. Will ticket in our tech debt epic
ryanthecoder
force-pushed
the
hw-testing-final-fixes-for-lld
branch
2 times, most recently
from
ff2d244 to
9630d8c
Compare
…rror resulting in moving to well.top resulting in the tip being below the liquid
ryanthecoder
force-pushed
the
hw-testing-final-fixes-for-lld
branch
from
e2f4549 to
f730fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test Plan
Changelog
Review requests
Risk assessment