-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app, protocol-designer, step-generation): schema v8 migration #13884
Conversation
export function protocolHasLiquids( | ||
protocol: ProtocolAnalysisFile<{}> | ProtocolAnalysisOutput | ||
): boolean { | ||
return 'liquids' in protocol && size(protocol.liquids) > 0 | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this util isn't being used anymore
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13884 +/- ##
==========================================
- Coverage 70.86% 70.86% -0.01%
==========================================
Files 2501 2501
Lines 70386 70388 +2
Branches 8613 8612 -1
==========================================
- Hits 49879 49878 -1
Misses 18404 18404
- Partials 2103 2106 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and fixes an issue where I couldn't add a new command to command schema 8 without things breaking!
Removed deck schema specification on request of rss here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No red flags for me! I tested this with a simple protocol and upload to the app worked as expected on a dev app build on this branch.
closes RAUT-828
Overview
This PR migrated the types in PD, step-generation, and the app to schema v8.
Test Plan
Create a protocol in PD without any deck configuration (no waste chute, staging area slots) and download. Upload it to the app. The app should function as expected and the protocol should say creation method PD 8.0.
Changelog
ProtocolAnalysisFile
fileCreator
in PD to match the new schema shapeNote: PD migration cypress test will be updated/thoroughly tested in a follow up PR!
Review requests
see test plan
Risk assessment
low