-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Experimental, barebones support for dropping stuff in the waste chute #13828
Conversation
Add simplified drop_tips_in_waste_chute.py. Copy in constants from the hardware team. Hack together some geometry computations for moving to the drop-tip location. Fucking cores. More core bullshit. hfuhhghh Circular import bullshit. Hack together a drop-tip-in-waste chute implementation. Apply minimum Z height. wip
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13828 +/- ##
=======================================
Coverage 70.74% 70.74%
=======================================
Files 1612 1612
Lines 53532 53532
Branches 3711 3711
=======================================
Hits 37873 37873
Misses 15050 15050
Partials 609 609
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good to me but can we move the test protos so i don't twitch
This PR was tested manually. We'll leave the automated tests out, for expedience.
This has been removed from the v7.1.0 launch.
Overview
This adds very experimental, unstable, internal methods to the Python Protocol API to let you eject tips and drop labware into the Opentrons Flex Waste Disposal Chute™.
This isn't specifically ticketed. It goes towards RSS-333 in general.
Changelog
ProtocolContext.load_waste_chute()
, which returns a newWasteChute
object.WasteChute
object toProtocolContext.move_labware()
as a destination.WasteChute
object toInstrumentContext.drop_tip()
as a destination.The implementation is hacky. For example, dropping a labware in a waste chute actually moves the labware "to slot D3" with a giant offset. We intend to change this when Protocol Engine learns about the waste chute. Hacky Python Protocol API support is beneficial for unblocking internal testers and sussing out API usability concerns.
Known limitations
drop_tip()
but notdispense()
orblow_out()
.move_to()
the waste chute.Test Plan
Here are a couple of test protocols. We need to run both of them on a Flex.
drop_labware_in_waste_chute.py
drop_tips_in_waste_chute.py
Review requests
Anything too hacky to tolerate?
Risk assessment