feat: add Precompiles trait #689
Conversation
✅ Deploy Preview for contracts-stylus canceled.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files
|
| /// Precompile primitives. | ||
| pub mod primitives { | ||
| /// The ecrecover precompile primitives. | ||
| /// | ||
| /// This module provides the cryptographic primitives needed for the | ||
| /// `ecrecover` precompile, which recovers the signer address from an | ||
| /// ECDSA signature and message hash. | ||
| /// | ||
| /// Re-exports selected ECDSA types and constants specifically relevant | ||
| /// to the ecrecover operation. | ||
| pub mod ecrecover { | ||
| pub use crate::utils::cryptography::ecdsa::{ | ||
| ECDSAInvalidSignature, ECDSAInvalidSignatureS, EcRecoverData, | ||
| Error, ECRECOVER_ADDR, SIGNATURE_S_UPPER_BOUND, | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
Didn't remove utils::cryptography::ecdsa for two reasons:
- The original crate can be expanded to include additional ECDSA-related operations, which have nothing to do with ecrecover precompile; the crate would be useful to devs as a standalone.
- Backward compatibility.
The mod primitives module is used to make it clear to devs where to find relevant precompile-related types, constants, enums etc.
In this specific case, the reason for this reexport is that it should be easier for the average Stylus developer to understand that the relevant ecrecover primitives are in the same module, i.e. precompiles::primitives::ecrecover, than that they should actually import them from a completely different module utils::cryptography::ecdsa.
|
CI should be fixed by #690 |
The idea is that each new precompile has its own function within Can you think of any precompile that would not work with this approach? |
Co-authored-by: Daniel Bigos <[email protected]>
That's already done:
@bidzyyys if both you and @qalisander support this approach, I'll update CHANGELOG and docs |
Proposal for unifying all precompiles in a single extension trait that can be more ergonomically invoked on contracts.
PR Checklist