Add ERC to ERC4337 interface names
#5468
Open
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ernestognw
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
LGTM, but I'd like @Amxx to be aware
This change is technically breaking but I don't think is a problem and keeps consistency. We should note it in the changelog though.
Nichebiche
reviewed
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #????
ERC4337 declares interfaces without the ERC present in them. To increase clarity, eliminate chance of interface name collision, and maintain consistancy with ERC7579 interfaces, this PR adds the ERC to the specced interface name.
PR Checklist
npx changeset add)