Treat code-size warnings as errors #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I'd say this is desirable, unless it triggers when compiling the "coverage" contract that are way bigger (because of the added events). CI shows that it should be ok, so I'd be in favor of it. We can revert back if it turns out its causing unforseen issues. |
Amxx
approved these changes
Feb 13, 2025
arr00
approved these changes
Feb 13, 2025
Amxx
added a commit
to Amxx/openzeppelin-contracts
that referenced
this pull request
Feb 14, 2025
Co-authored-by: Hadrien Croubois <[email protected]> Signed-off-by: Hadrien Croubois <[email protected]>
Dargon789
added a commit
to Dargon789/openzeppelin-contracts
that referenced
this pull request
Feb 15, 2025
* Update ReentrancyGuardTransient documentation (OpenZeppelin#5417) * Optimize `MerkleTree` for loops by using `uint256` iterators (OpenZeppelin#5415) Co-authored-by: Ernesto García <[email protected]> * Update `_revokeRole` documentation in AccessControl (OpenZeppelin#5321) Co-authored-by: Ernesto García <[email protected]> * Merge release-v5.2 branch (OpenZeppelin#5424) Signed-off-by: Hadrien Croubois <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hadrien Croubois <[email protected]> Co-authored-by: Sam Bugs <[email protected]> Co-authored-by: Ernesto García <[email protected]> Co-authored-by: Arr00 <[email protected]> Co-authored-by: wizard <[email protected]> Co-authored-by: leopardracer <[email protected]> Co-authored-by: cairo <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Francisco Giordano <[email protected]> Co-authored-by: Simka <[email protected]> Co-authored-by: Voronor <[email protected]> * Add a Calldata library with `emptyBytes` and `emptyString` functions (OpenZeppelin#5422) Co-authored-by: Ernesto García <[email protected]> * Update governor docs (OpenZeppelin#5420) * Add missing `Calldata`, `Bytes`, `CAIP2` and `CAIP10` API references (OpenZeppelin#5428) * Expose `_isTrustedByTarget` internally in ERC2771Forwarder (OpenZeppelin#5416) * Update LICENSE (OpenZeppelin#5434) * Refactor EnumerableSet.behavior.js for reuse in the community repo (OpenZeppelin#5441) * Replace `overriden` with `overridden` in GovernorCountingOverridable.sol (OpenZeppelin#5446) Co-authored-by: Arr00 <[email protected]> Co-authored-by: ernestognw <[email protected]> * Remove Unnecessary Initialisation of `_paused` (OpenZeppelin#5448) Co-authored-by: Ernesto García <[email protected]> * Fix Broken Docs References (OpenZeppelin#5436) * Update actions/upload-artifact action to v4 (OpenZeppelin#4826) * Remove unused `setBaseURI` tests (OpenZeppelin#5456) Co-authored-by: Hadrien Croubois <[email protected]> * Group typographical errors (OpenZeppelin#5443) Co-authored-by: futreall <[email protected]> Co-authored-by: Marco <[email protected]> Co-authored-by: Dmitry <[email protected]> Co-authored-by: Dmytrol <[email protected]> Co-authored-by: Noisy <[email protected]> Co-authored-by: Danil <[email protected]> Co-authored-by: CrazyFrog <[email protected]> Co-authored-by: Bryer <[email protected]> Co-authored-by: Viktor Pavlik <[email protected]> Co-authored-by: Skylar Ray <[email protected]> Co-authored-by: Brawn <[email protected]> Co-authored-by: fuder.eth <[email protected]> Co-authored-by: FT <[email protected]> Co-authored-by: Ann Wagner <[email protected]> Co-authored-by: Hopium <[email protected]> Co-authored-by: Arr00 <[email protected]> Co-authored-by: Hadrien Croubois <[email protected]> * Fix interface docs ordering and add missing interface (OpenZeppelin#5460) * Add a governor extension that implements a proposal guardian (OpenZeppelin#5303) Co-authored-by: Arr00 <[email protected]> Co-authored-by: Ernesto García <[email protected]> * Fix the CLI output of formal verification runs (OpenZeppelin#5445) * Update dependency halmos to v0.2.4 (OpenZeppelin#5461) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Use stable foundry version in CI (OpenZeppelin#5465) * Add stake management function to ERC4337Utils (OpenZeppelin#5471) * Add forum badge correct link (OpenZeppelin#5481) * SafeERC20.trySafeTransfer{,from} (OpenZeppelin#5483) * Improve promise rejections handling in hardhat/async-test-sanity.js (OpenZeppelin#5429) Co-authored-by: Arr00 <[email protected]> * Use slither v0.10.4 (OpenZeppelin#5488) * Add ERC6909 Implementation along with extensions (OpenZeppelin#5394) Co-authored-by: Hadrien Croubois <[email protected]> Co-authored-by: Ernesto García <[email protected]> * Rename ERC4337Utils ENTRYPOINT to ENTRYPOINT_V07 (OpenZeppelin#5472) Co-authored-by: Hadrien Croubois <[email protected]> * Add Bytes32x2Set (OpenZeppelin#5442) Co-authored-by: Ernesto García <[email protected]> * Add clear function to Enumerable{Set,Map} (OpenZeppelin#5486) Co-authored-by: Hadrien Croubois <[email protected]> * Make set-max-old-space-size.sh compatible with sh (OpenZeppelin#5493) Co-authored-by: Hadrien Croubois <[email protected]> * Update FUNDING.json (OpenZeppelin#5496) Co-authored-by: Hadrien Croubois <[email protected]> * Update FUNDING.json hierarchy (OpenZeppelin#5500) Co-authored-by: Hadrien Croubois <[email protected]> * Test behavior of SignatureChecker against the identity precompile (0x4) (OpenZeppelin#5501) * Treat code-size warnings as errors (OpenZeppelin#5101) Co-authored-by: Hadrien Croubois <[email protected]> * Make `TimelockController` receive function virtual (OpenZeppelin#5506) Co-authored-by: Arr00 <[email protected]> Co-authored-by: Hadrien Croubois <[email protected]> --------- Signed-off-by: Hadrien Croubois <[email protected]> Co-authored-by: Ernesto García <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: Maks <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hadrien Croubois <[email protected]> Co-authored-by: Sam Bugs <[email protected]> Co-authored-by: Arr00 <[email protected]> Co-authored-by: wizard <[email protected]> Co-authored-by: leopardracer <[email protected]> Co-authored-by: cairo <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Francisco Giordano <[email protected]> Co-authored-by: Simka <[email protected]> Co-authored-by: Voronor <[email protected]> Co-authored-by: Eric Lau <[email protected]> Co-authored-by: planetBoy <[email protected]> Co-authored-by: sudo rm -rf --no-preserve-root / <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renan Souza <[email protected]> Co-authored-by: futreall <[email protected]> Co-authored-by: Marco <[email protected]> Co-authored-by: Dmitry <[email protected]> Co-authored-by: Dmytrol <[email protected]> Co-authored-by: Noisy <[email protected]> Co-authored-by: Danil <[email protected]> Co-authored-by: CrazyFrog <[email protected]> Co-authored-by: Bryer <[email protected]> Co-authored-by: Viktor Pavlik <[email protected]> Co-authored-by: Skylar Ray <[email protected]> Co-authored-by: Brawn <[email protected]> Co-authored-by: fuder.eth <[email protected]> Co-authored-by: FT <[email protected]> Co-authored-by: Ann Wagner <[email protected]> Co-authored-by: Hopium <[email protected]> Co-authored-by: Yan Victor SN <[email protected]> Co-authored-by: Ursula <[email protected]> Co-authored-by: Michalis Kargakis <[email protected]> Co-authored-by: luca <[email protected]> Co-authored-by: Jonas <[email protected]> Co-authored-by: Joseph Delong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5099.
The current config is treating code size as a warning (
trueis equivalent to'warn'), which would not cause CI to fail. This config removes the line so that it's considered an error (according todefault: 'error'below).Feel free to close this if it's not the desired behavior.